Tracers detrainment due to sedimentation #4056
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
reviewed
Oct 16, 2025
| @. ᶜqʲₜ += ᶜinv_ρ̂ * vtt | ||
| @. Yₜ.c.sgsʲs.:($$j).q_tot += ᶜinv_ρ̂ * vtt | ||
| @. ᶜ∂ρ∂t_sed += vtt | ||
| vtt_sed_detrainment = @. lazy(min(0, |
There was a problem hiding this comment.
Since it's reused a couple of times, could you define this sedimentation detrainment as a standalone function to be called on different variables?
trontrytel
reviewed
Oct 16, 2025
| @. Yₜ.c.sgsʲs.:($$j).q_tot += ᶜinv_ρ̂ * vtt | ||
| @. ᶜ∂ρ∂t_sed += vtt | ||
| vtt_sed_detrainment = @. lazy(min(0, | ||
| -1 * ᶜρʲs.:($$j) * ᶜqʲ * ᶜwʲ * ᶜright_biased_∂a∂z)) |
There was a problem hiding this comment.
Could you add some documentation (either in the docs or in a code comment here) on how this term is derived?
trontrytel
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add tracers detrainment due to sedimentation
Content