-
Notifications
You must be signed in to change notification settings - Fork 27
ci: JET v0.10, v0.11 in .buildkite compat #4112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3f18865 to
ca2fc47
Compare
imreddyTeja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried running ci with 1.12 yet?
|
I have not run the entirety of ci, no. Perhaps we could chat about how to do this sometime?
This proposed change is mostly motivated by wanting to make use of quality-of-life improvements in v1.12; the simulations I've been running so far have not complained. It is impossible to precompile the |
I'm not completely confident in this, but I think precompile caches are in different folders for different Julia minor versions. |
ca2fc47 to
f4c88b8
Compare
f4c88b8 to
45b12eb
Compare
45b12eb to
e49ca15
Compare
- this enables support for Julia v1.12 - retain JET v0.9 to support Julia v1.11
dd184a1 to
ff12b9e
Compare
|
This change is part of the following stack: Change managed by git-spice. |
|
@imreddyTeja See the stacked PR for julia v1.12 status. I propose we merge this, which keeps buildkite to 1.11, but allows developer work with 1.12, then we can keep track of #4168 and what needs to be done for 1.12. A cursory glance at the failing tests suggests that bumping the ref counter should be sufficient. I haven't looked at how performance (SYPD) is affected. |
Uh oh!
There was an error while loading. Please reload this page.