Skip to content

Conversation

@haakon-e
Copy link
Member

@haakon-e haakon-e commented Dec 13, 2025

This pull request introduces support for selecting a predefined vertical mesh in the model configuration, specifically enabling the use of the "rcemipii" vertical mesh. The changes allow users to specify a vertical mesh type in the configuration files, and the codebase is updated to construct the appropriate mesh based on this setting.

Vertical mesh configuration and support:

  • Added a new vertical_mesh configuration option in default_config.yml to allow users to select the predefined "rcemipii" mesh.
  • Updated the rcemipii_box_CRM_1M.yml model configuration to use the new vertical_mesh: rcemipii option, and adjusted related vertical grid parameters (z_max, z_elem) to match the new mesh.

Codebase enhancements for mesh construction:

  • Modified the BoxGrid function in grids.jl to accept a vertical_mesh argument and construct the "rcemipii" mesh when specified, using a hardcoded boundary layer and uniform spacing in the free atmosphere.
  • Updated the get_grid function in type_getters.jl to pass the vertical_mesh parameter from parsed arguments to the grid constructor.

@haakon-e
Copy link
Member Author

haakon-e commented Dec 13, 2025

This change is part of the following stack:

Change managed by git-spice.

@haakon-e
Copy link
Member Author

cc: @oalcabes

@szy21
Copy link
Member

szy21 commented Dec 13, 2025

I'm not sure if it's a good idea to specify predefined meshes for different setups. It may be ok if we just add RCEMIP, but what if someone wants to add more specific setups in the future? If we do want to support this, I think it would be better to add the functionality to read an array of numbers for the vertical mesh from yaml.

This is just a thought, I would be interested in what others think.

@haakon-e
Copy link
Member Author

haakon-e commented Dec 14, 2025

yeah I agree. I am hoping I can wait until Nat gets the new interface merged so that I can (hopefully) define the mesh only in my simulation setup instead of "polluting" the shared simulation setup functions

@haakon-e haakon-e force-pushed the oa/fix_trace_gases_new branch from bafc1bc to 7bacb1e Compare December 15, 2025 01:33
@haakon-e haakon-e force-pushed the he/ft-rcemipii-vertical-mesh branch from d26fd04 to 7159df2 Compare December 15, 2025 01:33
@haakon-e haakon-e mentioned this pull request Dec 15, 2025
@haakon-e haakon-e force-pushed the he/ft-rcemipii-vertical-mesh branch from 7159df2 to 02e78f4 Compare December 15, 2025 01:59
@haakon-e haakon-e force-pushed the oa/fix_trace_gases_new branch from 8b328e1 to 1f322e8 Compare December 16, 2025 02:02
@haakon-e haakon-e force-pushed the he/ft-rcemipii-vertical-mesh branch from 02e78f4 to a4e8d62 Compare December 16, 2025 02:03
@oalcabes oalcabes force-pushed the oa/fix_trace_gases_new branch 2 times, most recently from 8e623de to d8ddcfd Compare December 16, 2025 21:58
Base automatically changed from oa/fix_trace_gases_new to main December 17, 2025 00:09
@haakon-e haakon-e force-pushed the he/ft-rcemipii-vertical-mesh branch from a4e8d62 to 307d5d8 Compare December 17, 2025 18:19
@haakon-e haakon-e changed the base branch from main to ne/split_divergence_minimal December 17, 2025 21:26
@haakon-e haakon-e force-pushed the he/ft-rcemipii-vertical-mesh branch from 307d5d8 to 9d82dcf Compare December 17, 2025 21:26
@szy21 szy21 force-pushed the ne/split_divergence_minimal branch from fe63cd6 to a0b31ad Compare December 17, 2025 21:29
@haakon-e haakon-e force-pushed the he/ft-rcemipii-vertical-mesh branch from 9d82dcf to 6cebf16 Compare December 17, 2025 21:31
@szy21 szy21 force-pushed the ne/split_divergence_minimal branch from a0b31ad to cf775cf Compare December 18, 2025 07:13
@haakon-e haakon-e changed the base branch from ne/split_divergence_minimal to main January 13, 2026 23:30
@haakon-e haakon-e force-pushed the he/ft-rcemipii-vertical-mesh branch from c05f9fc to bc7cf61 Compare January 13, 2026 23:30
@haakon-e haakon-e mentioned this pull request Jan 13, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants