modify surface conditions and update SurfaceFluxes #4198
+241
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
force-pushed
the
zs/surface_flux
branch
4 times, most recently
from
86d7c28 to
c16181d
Compare
Member
Author
|
working longrun: https://buildkite.com/clima/climaatmos-gpulongruns/builds/697 |
szy21
force-pushed
the
zs/surface_flux
branch
from
57b9b6a to
620d368
Compare
tapios
approved these changes
Jan 13, 2026
| parameterization = surf_state.parameterization | ||
| (; coordinates) = surface_local_geometry | ||
| FT = eltype(thermo_params) | ||
| Φ_sfc = SFP.grav(surface_fluxes_params) * coordinates.z |
Member
There was a problem hiding this comment.
Can we please just have a function for geopotential that we call here and elsewhere where we need it? I'd like to make the code easy to change to a geopotential with nonconstant g.
szy21
force-pushed
the
zs/surface_flux
branch
from
620d368 to
c9796dd
Compare
szy21
force-pushed
the
zs/surface_flux
branch
from
c9796dd to
930fdec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update to use the new SurfaceFluxes.
I won't merge this until land and coupler are updated and working correctly. But I would like to start getting reviews. Ignore the changes in toml and yml.
To-do
Content