GW drag parametrization #4208
Draft
GW drag parametrization #4208
+7,562
−1,055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but I had to move all the computations to cell-centred before doing a final interpolation of tau_sat from cell to face. This would inevitably change the results from the reference. Furthermore, there is now an error with calc_propagate_forcing./delete-remote.sh But whatever. I will be squishing this commit message. Committing to not lose my changes.
calc_base_flux should now be fully GPU ready
…g the correct output
in calc_saturation_profile. Because this implementation was using parent everywhere, face and cell arrays were not respected and assignments. This correction ensure consistency, but the final output remains the same.
…ill the top correction.
…ll allocating arrays on the fly
…ork a bit fast, but I am leaving this task aside for now
I have a lot of cleaning up to do
… everywhere giving up for now.
almost done
I now need to bring the kiddies back onto the cpu for plotting. As such, the solutions are not yet verified.
next step will refactoring. Mainly to make sure that I am not allocating arrays and all arrays in the cache are being used.
I should be able to run some analytical tests as a next step
there are some issues with how I initialised the fields, got to make them consistently faces now.
manifest, project, etc
but the computed drag is still a bit weak
As opposed to the hard-coded form from before
there are some difference, but the profiles remain largely the same.
Removed it previously, as I had not yet updated ClimaParams
30 arc sec seems to be crashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To-do
Content