Update scm setups - Small box #4209
Open
+56
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costachris
force-pushed
the
cc/update_scm
branch
5 times, most recently
from
03af420 to
8f67907
Compare
costachris
commented
Jan 13, 2026
costachris
changed the title
haakon-e
reviewed
Jan 13, 2026
Comment on lines
+583
to
+586
| function isbox(space) | ||
| h_space = Spaces.horizontal_space(space) | ||
| return Meshes.domain(Spaces.topology(h_space)) isa Domains.RectangleDomain | ||
| end |
Member
There was a problem hiding this comment.
perhaps instead of this, the iscolumn method could (for now) be updated to check that the horizontal domain has 1 elements and poly order 1? Not sure if practicable.
Member
Author
There was a problem hiding this comment.
I agree that's more concise. The column may be supported again after upstream ClimaCore changes, so I'll leave it for now to keep the box usage explicit.
costachris
force-pushed
the
cc/update_scm
branch
2 times, most recently
from
bbb8320 to
53fcf26
Compare
costachris
force-pushed
the
cc/update_scm
branch
3 times, most recently
from
b8505b3 to
1fc5874
Compare
costachris
force-pushed
the
cc/update_scm
branch
from
1fc5874 to
c095347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use small box for single column simulations. Addresses 0 horizontal velocity in current setups.