Wip on moisture fixer in dss #4210
Draft
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Will test in aquaplanet 1M and let you know how it looks. |
szy21
reviewed
Jan 13, 2026
| if tracer_name in propertynames(Y.c) | ||
| ρq_tot = Y.c.ρq_tot | ||
| tracer = getproperty(Y.c, tracer_name) | ||
| @. tracer += min(max(0, -tracer), max(0, ρq_tot)) |
Member
There was a problem hiding this comment.
Note that the sum of the change in tracers (e.g. if all four are negative) can still be larger than ρq_tot because it is constrained individually. I guess we don't want to have an artificial order for the clipping. But then, do we need the constraint of ρq_tot at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we discussed today - apply "moisture fixer" inside dss to fix small tracer at the expense of water vapor