Skip to content

Conversation

@haakon-e
Copy link
Member

@haakon-e haakon-e commented Jan 13, 2026

This pull request removes all dependencies and related CI/test scripts for the JET static analysis tool from the project. The main focus is on cleaning up the codebase and build configuration by eliminating JET-related files, dependencies, and CI steps.

Copy link
Member

@dennisYatunin dennisYatunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing these! The number of JET failures for the current main branch is 236, but it doesn't look like any of those failures are correlated with actual performance issues. While tests like this are useful for simple functions in ClimaCore, they appear to mostly be catching instabilities in the high-level interface of ClimaAtmos and its various dependencies. If these instabilities aren't affecting performance on GPUs (either runtime or latency), removing the tests is a good idea.

@haakon-e haakon-e force-pushed the he/chore-ci-remove-jet-tests branch from 0763522 to 02a36ca Compare January 14, 2026 00:23
@haakon-e
Copy link
Member Author

Seems like buildkite does not complete gpu jobs. Need to merge #4215 then rerun ci here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants