Canopy roughness parameterization modular #1505
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Our default sets roughness lengths for the canopy as parameters using the toml. In almost all our example, though, we override these by using a constant times the canopy height. This PR updates the default so that it does what we want
This also creates a roughness parameterization struct which we can dispatch off of when computing surface fluxes. Since the shared canopy parameter struct then only has the earth param set, we can remove that from our code; this also enables us to change roughness paramterizations in the future
Closes #1351
To-do
Content