Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a pertubation advection open boundary matching scheme #3977

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
d992d81
fix FEOBC
jagoosw Nov 18, 2024
2a374cb
x-boundary condition implemented
jagoosw Dec 4, 2024
babe922
changed relaxation a bit
jagoosw Dec 5, 2024
32cd354
cleaning up + validation case
jagoosw Dec 6, 2024
5a0285f
changed to pointwise
jagoosw Dec 6, 2024
fef6185
oops
jagoosw Dec 6, 2024
fa5a471
fixed open boundary filling + tests
jagoosw Dec 6, 2024
29a3b4a
Merge branch 'main' into jsw/fix-feobc
jagoosw Dec 6, 2024
b55395c
generalised and fixed bug in left boundary
jagoosw Dec 6, 2024
1a9fbec
bump patch
jagoosw Dec 6, 2024
e66f3d1
Formating
jagoosw Dec 6, 2024
dc73eba
Merge branch 'main' into jsw/fix-feobc
jagoosw Dec 10, 2024
51c9938
test problem
jagoosw Dec 10, 2024
94ce249
Merge branch 'main' into jsw/fix-feobc
jagoosw Dec 10, 2024
6ff1bc7
bump patch
jagoosw Dec 10, 2024
b10f833
Merge remote-tracking branch 'origin' into jsw/pertubation-advection-obc
jagoosw Dec 10, 2024
a7cdcfd
Merge branch 'main' into jsw/fix-feobc
jagoosw Dec 11, 2024
62e27b2
clean up
jagoosw Dec 12, 2024
a23adae
boundary normal velocity
jagoosw Dec 12, 2024
5246c9a
oops
jagoosw Dec 12, 2024
a34c927
Rename
jagoosw Dec 12, 2024
0df1abe
finish renaming
jagoosw Dec 12, 2024
ff0c79e
renamed
jagoosw Dec 12, 2024
3257eec
kind of GPU frieldly
jagoosw Dec 12, 2024
07cc471
typo
jagoosw Dec 13, 2024
9ae0b66
bug
jagoosw Dec 13, 2024
ec9dd88
bug
jagoosw Dec 13, 2024
9859c17
Merge branch 'main' into jsw/fix-feobc
jagoosw Dec 14, 2024
0e02a2b
Merge branch 'main' into jsw/fix-feobc
jagoosw Dec 15, 2024
9912b51
Merge remote-tracking branch 'origin/jsw/fix-feobc' into jsw/pertubat…
jagoosw Dec 15, 2024
96495b1
allow forward euler integration
jagoosw Dec 15, 2024
c49ed26
fix adapt
jagoosw Dec 15, 2024
842ef63
mistake
jagoosw Dec 17, 2024
73cd923
changed a function name
jagoosw Dec 17, 2024
57261e2
Merge branch 'main' into jsw/pertubation-advection-obc
jagoosw Dec 30, 2024
b961259
fix src/Oceanaingans conflicts (?)
jagoosw Dec 30, 2024
9f30bbf
Merge branch 'main' into jsw/pertubation-advection-obc
jagoosw Jan 14, 2025
85bf032
Merge branch 'main' into jsw/pertubation-advection-obc
tomchor Jan 15, 2025
895d3f2
Merge branch 'main' into jsw/pertubation-advection-obc
tomchor Jan 16, 2025
6bb4bbf
add x and y directions
jagoosw Jan 18, 2025
e412995
added test
jagoosw Jan 18, 2025
549e4cd
Merge branch 'main' into jsw/pertubation-advection-obc
jagoosw Jan 18, 2025
dddb91a
Merge branch 'main' into jsw/pertubation-advection-obc
jagoosw Jan 20, 2025
00d56cf
Apply suggestions from code review
jagoosw Jan 21, 2025
0de469d
commented tests
jagoosw Jan 21, 2025
270d26a
tidied up validation
jagoosw Jan 21, 2025
f20894e
fixed adapt
jagoosw Jan 22, 2025
ef4d4d7
fix validation case
jagoosw Jan 22, 2025
2b15848
Update validation/open_boundaries/cylinder.jl
jagoosw Jan 22, 2025
d12414c
added plotting to validation
jagoosw Jan 22, 2025
335926e
added explanation to docstring
jagoosw Jan 22, 2025
c3241ca
corrected validation script
jagoosw Jan 22, 2025
fa94dd1
Merge branch 'main' into jsw/pertubation-advection-obc
jagoosw Jan 22, 2025
35f42b2
removed @allowscalars
jagoosw Jan 22, 2025
a13ffd2
Merge branch 'main' into jsw/pertubation-advection-obc
tomchor Jan 24, 2025
97959c5
updated docstring
jagoosw Jan 27, 2025
20887f5
removed \vec characters
jagoosw Jan 28, 2025
608c3c8
Merge branch 'main' into jsw/pertubation-advection-obc
jagoosw Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions validation/open_boundaries/cylinder.jl
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ using Oceananigans.BoundaryConditions: FlatExtrapolationOpenBoundaryCondition,
Returns the drag within the `bounding_box` computed by:

∂ₜu⃗ + (u⃗⋅∇)u⃗ = −∇P + ∇⋅τ⃗ + F⃗
F⃗ₜ =∫ᵥF⃗dV = ∫ᵥ(∂ₜ u⃗ + (u⃗⋅∇)u⃗ + ∇P − ∇⋅τ⃗)dV
F⃗ₜ=∫ᵥ(∂ₜu⃗)dV + ∮ₛ(u⃗(u⃗⋅n̂) + Pn̂ − τ⃗⋅n̂)dS
Fᵤ=∫ᵥ ∂ₜu dV + ∮ₛ(u(u⃗⋅n̂) − τₓₓ)dS + ∮ₛPx̂⋅dS⃗
Fᵤ=∫ᵥ ∂ₜ u dV − ∫ₛ₁(u² − 2ν∂ₓ u + P)dS + ∫ₛ₂(u² − 2ν∂ₓ u+P)dS − ∫ₛ₃uvdS + ∫ₛ₄ uvdS
F⃗ₜ = ∫ᵥF⃗dV = ∫ᵥ(∂ₜ u⃗ + (u⃗⋅∇)u⃗ + ∇P − ∇⋅τ⃗)dV
F⃗ₜ = ∫ᵥ(∂ₜu⃗)dV + ∮ₛ(u⃗(u⃗⋅n̂) + Pn̂ − τ⃗⋅n̂)dS
Fᵤ = ∫ᵥ ∂ₜu dV + ∮ₛ(u(u⃗⋅n̂) − τₓₓ)dS + ∮ₛPx̂⋅dS⃗
Fᵤ = ∫ᵥ ∂ₜ u dV − ∫ₛ₁(u² − 2ν∂ₓ u + P)dS + ∫ₛ₂(u² − 2ν∂ₓ u+P)dS − ∫ₛ₃uvdS + ∫ₛ₄ uvdS
tomchor marked this conversation as resolved.
Show resolved Hide resolved

where the bounding box is ``V`` which is formed from the boundaries ``s1``, ``s2``, ``s3``, and ``s4``
which have outward directed normals ``-x̂``, ``x̂``, ``-ŷ``, and ``ŷ``
Expand Down
Loading