Skip to content

Update boundary conditions before pressure solve #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Jun 4, 2025

No description provided.

@glwagner glwagner marked this pull request as draft June 4, 2025 15:30
@tomchor
Copy link
Collaborator

tomchor commented Jun 4, 2025

I don't see any difference in my simulations after this change. As an example, here's a headland simulation (similar to the paper one but with the original concave bottom) without this change, using an fft solver:

channel_16_fft_15.mp4

and the same simulation with this change:

channel_16.mp4

(Note that both simulations above also use the changes done in #4539)

@glwagner
Copy link
Member Author

glwagner commented Jun 4, 2025

is there any change in the predictor velocity?

@glwagner
Copy link
Member Author

glwagner commented Jun 4, 2025

The difference could be small, so I would look at the pointwise difference betwween the solutions. note that because we are talking about details associated with time-dependence, the difference in results should depend on the time-step, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants