-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Panel types #466
base: main
Are you sure you want to change the base?
Export Panel types #466
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,3 @@ | |||
export type PanelPadding = "none" | "xs" | "sm" | "md" | "lg" | "xl"; | |||
export type PanelColor = "default" | "muted" | "transparent"; | |||
export type PanelRadii = "none" | "sm" | "md" | "lg"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these come from the Theme and are centralised. These should not be specified here.
They should be common to all components that use sizing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Firefds Why are we exporting these?
Where are we using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vineethasok I also had the need to use these types before, whenever we are trying to specify something on a variable and not inputting them directly in the component.
For one reason or another this seems to be required to be exported from ClickUI.
These should be centralised and exported.
@Firefds one way I was able to deal without the import of the specific type in my code was to specify something like PanelProps['color']
No description provided.