feat(ButtonGroup): update design #626
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ariser
commented
Jul 2, 2025
| // TODO remove css variables for radii? | ||
| border-radius: ${({ theme, $type }) => | ||
| $type === "default" | ||
| ? `calc(${theme.click.button.group.radii.all} - var(--outer-spacing))` |
There was a problem hiding this comment.
this does not exactly match what we have in figma
why
nested border-radii are a bit tricky to implement. If the outer radius matches the inner radius, they can look fine when an element in the middle is selected:
But when the selected area corner is right next to the outer border area, they start to conflict. Here it's obvious that the spacing around the inner element increases around the corner:
To avoid this, inner radius should be reduced by the size of the space between the outer border and the inner element:
here is a playground to see how it feels:
https://borderradiuscalculator.vercel.app/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why
Right now it's impossible to tell which one of the two options in ButtonGroup is selected:
This update aims to make visuals more clear:
ToDos: