Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split kafka docs #1513

Merged
merged 8 commits into from
Oct 20, 2023
Merged

split kafka docs #1513

merged 8 commits into from
Oct 20, 2023

Conversation

mshustov
Copy link
Member

Get back the structure introduced in #740

@mshustov mshustov requested a review from Ryado September 10, 2023 09:12
@mshustov mshustov requested a review from a team as a code owner September 10, 2023 09:12
@robot-ch-test-poll2
Copy link

robot-ch-test-poll2 commented Sep 10, 2023

This is an automated comment for commit ac6baba with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Docs CheckBuilds and tests the documentation✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
VercelThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success

Copy link
Contributor

@Ryado Ryado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some substantial changes and pushed them in the last commit

@Ryado
Copy link
Contributor

Ryado commented Oct 20, 2023

Can you have a look @mshustov ?

@Felixoid
Copy link
Member

So, the changes from ecf6e77 work in https://github.com/ClickHouse/clickhouse-docs/actions/runs/6589667297/job/17904622695?pr=1513

I force push them back, and we'll merge ClickHouse/ClickHouse#55874 ASAP

@mshustov mshustov merged commit 8f04357 into main Oct 20, 2023
5 of 6 checks passed
@mshustov mshustov deleted the kafka2 branch October 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants