Skip to content

chore: fix image links in clickhouse docs #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

lpmi-13
Copy link
Contributor

@lpmi-13 lpmi-13 commented Dec 3, 2024

Summary

The image links in the clickhouse data viz docs were broken. This commits fixes them. I can also center the images if that would be preferable than the default, which is left-aligned.

I also fixed a couple double spaces after periods, but I can rebase that out if you prefer.

Checklist

@lpmi-13 lpmi-13 requested a review from a team as a code owner December 3, 2024 23:58
@lpmi-13 lpmi-13 requested review from pjhampton and removed request for a team December 3, 2024 23:58
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@iamKunalGupta iamKunalGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images are loading fine for me, but good to have it in the new syntax anyways.

Thanks for your contribution!

@lpmi-13
Copy link
Contributor Author

lpmi-13 commented Dec 4, 2024

Ah right...sorry, should have included screenshots indicating I was referring to the github repo markdown specifically.

The pictures load fine on the main docs site, but I got directed to this repo during googling and was surprised that the images didn't show up.

Screenshot_20241204_005355_Firefox

@serprex serprex merged commit f9410d9 into ClickHouse:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants