Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant data type support #170

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Variant data type support #170

wants to merge 6 commits into from

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Oct 31, 2024 •
edited
Loading

Summary

Adds support for the Variant data type. Closes #143.

To discuss:

  • can we make a convenience macro to generate the enum? Or is it more of the ch2rs responsibility in this case?

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided so that we can include it in CHANGELOG later
  • For significant changes, documentation in README and https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@serprex serprex requested review from loyd and serprex October 31, 2024 19:28
serprex
serprex previously approved these changes Oct 31, 2024
View reviewed changes
@mshustov mshustov requested a review from serprex November 5, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov left review comments

@loyd loyd Awaiting requested review from loyd

@serprex serprex Awaiting requested review from serprex

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Variant(T1, T2, ...) data type
3 participants
@slvrtrn @serprex @mshustov