fix(ser): fix i128/u128 SQL bind serialization #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marcin-ptaszynski
force-pushed
the
fix-ser-int128
branch
2 times, most recently
from
a4b7a02 to
796b1cf
Compare
serprex
previously approved these changes
Mar 17, 2025
marcin-ptaszynski
force-pushed
the
fix-ser-int128
branch
3 times, most recently
from
e93c039 to
972fc38
Compare
Integer types larger than 64 bits cannot be written as literals without casting, or they end up `Float64`. See ClickHouse/ClickHouse#38480 This commit fixes ClickHouse#208
marcin-ptaszynski
force-pushed
the
fix-ser-int128
branch
from
972fc38 to
99a24a1
Compare
slvrtrn
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integer types larger than 64 bits cannot be written as literals without casting, or they end up parsed as
Float64. See ClickHouse/ClickHouse#38480This commit fixes #208
Checklist
Delete items not relevant to your PR: