Add UUID/invocation ID to temporary table names #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync Github dap-main with Gitlab dap-main
Magicbeanbuyer
changed the title
|
Thank you for your contribution! |
BentsiLeviav
reviewed
Jan 5, 2025
| @@ -208,7 +208,7 @@ | |||
| {%- endmacro %} | |||
|
|
|||
| {% macro clickhouse__insert_into(target_relation, sql, has_contract) %} | |||
| {%- set dest_columns = adapter.get_columns_in_relation(target_relation) -%} | |||
| {%- set dest_columns = adapter.get_column_schema_from_query(sql) -%} | |||
There was a problem hiding this comment.
Could you explain why this change is required? why change the columns getter from the target relation to the SQL?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Append invoication_id to table name of temporary, intermediate and backup tables to avoid name collision between dbt runs.
Checklist
Delete items not relevant to your PR: