Skip to content

Assert that resources is map like before treating as a map #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

Garbett1
Copy link

Description:

Link to tracking Issue:

Testing:

Documentation:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@RoryCrispin
Copy link

it would be interesting to share where you hit a bug here

@Garbett1
Copy link
Author

Hit a panic when trying to extract a resource from a log record that didn't have it. Decided to cover more scenarios by checking existence + that it is actually a map.

@Garbett1 Garbett1 marked this pull request as ready for review January 12, 2025 20:23
@Garbett1 Garbett1 merged commit 0d9bc58 into main Jan 13, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants