Join endpoint_configuration
and endpoints
into single field and m…
#273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ake changes to the plan more understandable
Towards: #267
but a general improvement overall.
This PR aims at simplifying and improving the management of endpoints (read protocols) in a clickhouse service in both directions (input or enable/disable and output to get the host and port for each endpoint).
The change is twofold:
endpoint_configuration
attribute and move endpoint config to theendpoints
attribute.endpoints
attribute from being a list to a map.Example.
Before this change, to enable the
mysql
endpoint (the only configurable one) one needed to have this in .tf fileand the output would have been something like this:
After this change, users need to use the
endpoints
field for both enabling the mysql endpoint (and possibly others in the future) and get the hostnames, in a better format like this:and the outputs
the main advantage of this change is that we can have a more fine grained control over the plan when changing endpoint settings, and avoid having all endpoints show up as "known after apply" everytime there was a change.
This has been a rightful request from a few customers.