fix: apply version filtering and fix supplementary dataset selection in regression analysis#554
Open
lewisjared wants to merge 5 commits intomainfrom
Open
fix: apply version filtering and fix supplementary dataset selection in regression analysis#554lewisjared wants to merge 5 commits intomainfrom
lewisjared wants to merge 5 commits intomainfrom
Conversation
Contributor
Author
|
@bouweandela what do you think about 1cb40c0 ? |
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two issues in the dataset selection logic that caused spurious entries in regression analysis results:
Version filtering in dataset queries (
datasets/base.py): Added properversionfiltering toquery_datasetsandquery_facetsmethods. Previously, version constraints were silently ignored, causing older dataset versions to leak into results. The version filter supports both exact matching and ordering comparisons (e.g.v20190731vsv20200101).Supplementary dataset selection (
constraints.py): FixedAddSupplementaryDatasetto pick a single best-matching dataset per group instead of accumulating multiple candidates across score ties. Previously, when multiple supplementary datasets tied on matching score, all were selected, leading to spurious experiment entries (e.g.1pctCO2,esm-1pct-brch-1000PgC) appearing alongside expectedhistoricaland SSP data.These fixes together eliminate unexpected experiment/version combinations from regression outputs.
Checklist
Please confirm that this pull request has done the following:
changelog/