Added: database_type to configuration #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizdeika
force-pushed
the
add-database_type-to-configuration
branch
from
c92002c
to
232352f
Compare
lizdeika
force-pushed
the
add-database_type-to-configuration
branch
from
232352f
to
b6019ac
Compare
|
Hi, |
|
How we will handle this with activerecord 6 that support multiple database.? |
lizdeika
force-pushed
the
add-database_type-to-configuration
branch
from
b6019ac
to
df3446e
Compare
|
IMHO this one is better #338 since it's compatible with Rails 6 multi DB support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #338
Adds ability to set
database_typeininitializers/closure_tree_config.rb:The type will be used across all the closure tree models in the application.
This solves problems with numeric ordering and
db:create.