Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the current implementation with root ordering there is a problem described in the readme
Also, changing the order of the root nodes is quite problematic since they are ordered globally as mentioned earlier.
Typical situation - I want to get all root blocks of a user and change their order:
But in this case, the sort_order for all root nodes of one user will be a sparse sequence of 1, 10, 48 ....
I was thinking that in the case where
parent_id = nil
, you could rely on associations to restrict sort_order to root nodes within the association scope.My option to implement this as simply as possible is to add an
order_belong_to
option, through which the foreign key field for the corresponding association is provided.