Skip to content

Serialize Path objects as absolute paths for RPC #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: nightly
Choose a base branch
from

Conversation

DasBabyPixel
Copy link
Contributor

Motivation

#1303

Modification

Only send the path as an absolute path over RPC

Result

Relative paths can be used with pull and work correctly

Other context

Fixes #1303

@derklaro
Copy link
Member

I think it's an oversight that pull uses RPC, imo it should use the chunked data transfer like the other methods as well.

@DasBabyPixel
Copy link
Contributor Author

I think it's an oversight that pull uses RPC, imo it should use the chunked data transfer like the other methods as well.

you're probably correct. I also don't know if this works well in clusters. I just know this fixes the issue for me, even if it is not ideal

@derklaro
Copy link
Member

I can fix the pull method later. I'm not sure if the path serializer is a good idea at all, maybe we should just remove it. If we leave it, then it probably shouldn't serialize absolute paths, and leave the decision about aboslute vs relative paths to the caller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TemplateStorage#pull does not work in wrapper with relative paths
2 participants