Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constants #148

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Add constants #148

merged 6 commits into from
Aug 30, 2024

Conversation

Enn3Developer
Copy link
Member

Closes #147
Add const support for Lua 5.4; it implicitly add local to all consts

@Enn3Developer Enn3Developer added the enhancement New feature or request label Jun 26, 2024
@Enn3Developer Enn3Developer marked this pull request as ready for review June 26, 2024 13:23
@Maiori44
Copy link
Member

Maiori44 commented Jul 4, 2024

figured I'd say it here too
shouold this be for 4.0 or 3.X?

@Markos-Th09
Copy link
Member

figured I'd say it here too shouold this be for 4.0 or 3.X?

I think we can go with this:

  • Ship the version with no constness guarantees for 3.x
  • Figure out the rest in 4.x

Maiori44
Maiori44 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Maiori44 Maiori44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems alright

@Maiori44 Maiori44 merged commit c315eb6 into ClueLang:main Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maiori44 Maiori44 Maiori44 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce constants
3 participants
@Enn3Developer @Maiori44 @Markos-Th09