Hmt 5-landing hero section #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliey16
force-pushed
the
hmt-5/landing-hero-section
branch
from
0782918 to
410f8e7
Compare
topanb11
reviewed
Mar 24, 2024
nataliey16
force-pushed
the
hmt-5/landing-hero-section
branch
from
5a5e909 to
fcefa23
Compare
ideen1
requested changes
Mar 27, 2024
| </h1> | ||
| <div className={TIMER_CONTAINER}> | ||
| <div className="flex space-x-3"> | ||
| <div className={TIMER_BACKGROUND}> |
There was a problem hiding this comment.
Thanks for refactoring that! I think what Topan meant is to make each of these 4 blocks one component. That way you just call the component in a loop and pass a different object into each one. I.e. {name:minutes, value:34}, {name:hours, value :1}
There was a problem hiding this comment.
Thanks for the clarification, Ideen! I believe I fixed it to what you and Topan suggested. Although, let me know if it needs further adjustments.
… validationfor each time block
nataliey16
force-pushed
the
hmt-5/landing-hero-section
branch
from
fcefa23 to
fab498f
Compare
ideen1
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a responsive hero section for the landing page. It contains a countdown timer for the date of the Hackathon (temporary date - Nov 10, 2024) that appears on desktop and disappears on mobile. When that date approaches, "Hack the Change XXXX has begun!" will appear. Right now, the timer re-loads after refreshing the page. There is likely a more efficient way to build this and have it pre-render by possibly using getStaticProps and Contentful (or if there is even a better way, let me know!).
I also have been struggling to find a better way to add a purple text-border around "Hack the Change 2024." The CTC website uses tailwind css (text-stroke-outside) but this doesn't seem to work here.