Merged
Conversation
Co-authored-by: justin-phxm <113923596+justin-phxm@users.noreply.github.com> Co-authored-by: hannagracec <hannacho847@gmail.com> Co-authored-by: Natalie <natalie.yeung16@gmail.com> Co-authored-by: natalie.yeung <102062208+nataliey16@users.noreply.github.com> Co-authored-by: Hanna <144185720+hannagracec@users.noreply.github.com> Co-authored-by: Burton Jong <108391733+burtonjong@users.noreply.github.com>
Co-authored-by: justin-phxm <113923596+justin-phxm@users.noreply.github.com> Co-authored-by: hannagracec <hannacho847@gmail.com> Co-authored-by: Natalie <natalie.yeung16@gmail.com> Co-authored-by: natalie.yeung <102062208+nataliey16@users.noreply.github.com> Co-authored-by: Hanna <144185720+hannagracec@users.noreply.github.com> Co-authored-by: Burton Jong <108391733+burtonjong@users.noreply.github.com>
ideen1
reviewed
Mar 29, 2024
Contributor
ideen1
left a comment
ideen1
left a comment
There was a problem hiding this comment.
Can you merge main into your branch? There seems to be some significant changes with Headers and such that made on main since you made this branch that are preventing it from building on my machine.
Contributor
Author
|
Should work now |
ideen1
previously approved these changes
Apr 4, 2024
burtonjong
dismissed
ideen1’s stale review
The merge-base changed after approval.
burtonjong
dismissed
ideen1’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop View:
IPhone SE View:
IPhone XR View:
The reason why I added the IPhoneSE and IPhoneXR view is because of the improvisations that me and @nataliey16 made. When decreasing screen width, the squiggly lines move closer to the header but never end up overlapping. Hopefully this looks okay and am willing to take any feedback on it.
When hovering an image, the sponsor name will appear under the image.
I also need feedback because on the CTC website, most of the sponsors images are not circular. Thus, if we do not have circular sponsor images some change will have to be made to accomodate for whatever shape they are. I also suggest (although if it looks fine then no changes need to be made) but the layout on the mobile view should not be a 5x1, but rather 2x2 or 2x3 (depending on the number of images).