Hmt 44/qr code component #40
Conversation
There was a problem hiding this comment.
Hey! I just took a quick look at the UI and the QR code looks super nice. In terms of the layout, maybe put all of the QR content including the text in a panel similar to the other profile pages on the Figma? Maybe something like this:
I think the vertical look is nice as well just a panel might help make it look cohesive with the other pages!
There was a problem hiding this comment.
Looks great and amazing. I should have made things clearer in the README and the sample. This MAC address stuff is complicated cryptography so it's pretty easy to get confused. Thanks for all the hard work!
Also, you can test to see if your QR code works by creating a FoodEvent in the admin page, and scanning the QR code (or inputting the value of the QR code) into the admin food ticket scanner page.
|
|
|
@burtonjong it got changed to username from userSub. Merge main and try that. UserSub wasn't compatible with the Google OAuth flow. But username works universally, it's the exact same value |
There was a problem hiding this comment.
Make sure you test the script to make sure it is working with the food ticket scanner, but at the high level, it looks like it is good. Also, if it is a huge issue that the user code is too long, you could edit the crytography util class and cutoff the MAC generation code (as in the generated code string), then it should continue to work fine.
Also the logo change @burtonjong |
Not done yet, just need feedback on the look of it