Skip to content

Hmt 20 team registration page #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Jul 30, 2024
Merged

Hmt 20 team registration page #53

merged 47 commits into from
Jul 30, 2024

Conversation

justin-phxm
Copy link
Contributor

55 files changed
15000 additions
1539 deletions

GG it's over

@ideen1
Copy link
Contributor

ideen1 commented Jul 3, 2024

@justin-phxm Status update: still on my list, let's find time to meet to discuss

Copy link
Contributor

@ideen1 ideen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin-phxm Since we haven't been able to talk yet can you please revert moving the files under (authentication), etc. Essentially any files you moved please place them back for now. I like the organization better and I see the goal but it's just way too many changes in one PR to effectively check. We can do a speerate PR to mvoe thing in a way you think is better organized.

Copy link
Contributor

@ideen1 ideen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with (team) and stuff

@ideen1 ideen1 changed the base branch from main to prod July 19, 2024 01:07
@ideen1 ideen1 changed the base branch from prod to main July 19, 2024 01:07
@justin-phxm justin-phxm force-pushed the HMT-20-team-registration-page branch from e7fa119 to fe05b8b Compare July 21, 2024 23:47
@justin-phxm justin-phxm force-pushed the HMT-20-team-registration-page branch from 6b3b2ed to 1a55b07 Compare July 26, 2024 00:33
@ideen1 ideen1 changed the base branch from main to prod July 26, 2024 07:19
@ideen1 ideen1 changed the base branch from prod to main July 26, 2024 07:19
@ideen1 ideen1 self-requested a review July 30, 2024 00:47
Copy link
Contributor

@ideen1 ideen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!

@ideen1 ideen1 merged commit 4618aeb into main Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants