Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for deeplinks #1401

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix for deeplinks #1401

merged 1 commit into from
Aug 7, 2023

Conversation

Wouter01
Copy link
Member

@Wouter01 Wouter01 commented Aug 7, 2023

Description

Fixes deeplinks not working

Related Issues

  • #ISSUE_NUMBER

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@Wouter01
Fix for deeplinks
e31af9a 
Signed-off-by: Wouter01 <[email protected]>
austincondiff
austincondiff approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised how simple that fix is! Thanks for taking care of this!

@austincondiff austincondiff merged commit fbdf2fc into main Aug 7, 2023
2 checks passed
@austincondiff austincondiff deleted the deeplink-fix branch August 7, 2023 18:19
@thecoolwinter thecoolwinter added the bug Something isn't working label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombardier200 bombardier200 bombardier200 approved these changes

@austincondiff austincondiff austincondiff approved these changes

@0xWDG 0xWDG Awaiting requested review from 0xWDG

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wouter01 @austincondiff @bombardier200 @thecoolwinter