-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): Add fuzzy search for filtering and sorting themes in settings #1849
Conversation
I appreciate the PR, but is this something users want/need? We might do this in the Quick Actions overlay when we get to that point. ⇧⌘A, Type "Theme", press enter, Quick actions then displays a searchable list of all themes for you to choose from. To go back users can press something like Esc or Backspace similar to Raycast. |
I completely agree that users would likely use the Quick Action overlay to achieve the same result. However, I believe that every list in an application, regardless of its content, should have a search field if possible. It doesn’t need to be visible at all times, but perhaps we could include a button that reveals a search field when needed. |
- Add functionality for the plus button - Add menu (still not working)
Can you update that old screenshot with a new screen recording showcasing your changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a crash when deleting themes
CodeEdit/Features/Settings/Pages/ThemeSettings/ThemeSettingsView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great, other than that flash when you close the theme sheet we had discussed. I don’t think this should hold back this PR but could you create an issue for this so it can be addressed later?
Description
Added a basic fuzzy search feature to the themes settings page (#1760). This utilizes the existing algorithm and will help users find themes much faster.
Related Issues
Checklist
Screenshots
Screen.Recording.2024-09-09.at.7.35.41.PM.mov