Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): Add fuzzy search for filtering and sorting themes in settings #1849

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

tom-ludwig
Copy link
Member

@tom-ludwig tom-ludwig commented Aug 14, 2024

Description

Added a basic fuzzy search feature to the themes settings page (#1760). This utilizes the existing algorithm and will help users find themes much faster.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-09-09.at.7.35.41.PM.mov

@austincondiff
Copy link
Collaborator

austincondiff commented Aug 14, 2024

I appreciate the PR, but is this something users want/need? We might do this in the Quick Actions overlay when we get to that point. ⇧⌘A, Type "Theme", press enter, Quick actions then displays a searchable list of all themes for you to choose from. To go back users can press something like Esc or Backspace similar to Raycast.

@tom-ludwig
Copy link
Member Author

I completely agree that users would likely use the Quick Action overlay to achieve the same result. However, I believe that every list in an application, regardless of its content, should have a search field if possible. It doesn’t need to be visible at all times, but perhaps we could include a button that reveals a search field when needed.

@thecoolwinter thecoolwinter marked this pull request as ready for review August 21, 2024 02:59
@thecoolwinter thecoolwinter marked this pull request as draft August 21, 2024 02:59
@austincondiff
Copy link
Collaborator

Can you update that old screenshot with a new screen recording showcasing your changes?

Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a crash when deleting themes

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great, other than that flash when you close the theme sheet we had discussed. I don’t think this should hold back this PR but could you create an issue for this so it can be addressed later?

@thecoolwinter thecoolwinter merged commit 9251301 into main Sep 23, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the feat/1760/fuzzy-search-themes branch September 23, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add a TextField to Filter Themes
3 participants