Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing tabs while Open Quickly or Command Palette is open is no longer allowed. #1868

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Closing tabs while Open Quickly or Command Palette is open is no longer allowed. #1868

merged 5 commits into from
Sep 28, 2024

Conversation

scaredcr6w
Copy link
Contributor

Description

When Open Quickly or Command Palette is open, open tabs are no longer allowed to be closed using cmd + w

Related Issues

Close tab works when the 'Open Quickly' or 'Quick Actions' modal is open closes #1796

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Kepernyofelvetel.2024-08-27.-.12.29.43.mov

austincondiff
austincondiff requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small changes

CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift Outdated Show resolved Hide resolved
@austincondiff austincondiff merged commit 1255659 into CodeEditApp:main Sep 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-ludwig tom-ludwig tom-ludwig approved these changes

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@FastestMolasses FastestMolasses Awaiting requested review from FastestMolasses

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Close tab works when the 'Open Quickly' or 'Quick Actions' modal is open
3 participants
@scaredcr6w @austincondiff @tom-ludwig