Bold and italic text formatting in themes

[austincondiff]

Description

We are adding bold and italic text formatting to existing bundled themes and providing the ability for user to configure custom themes to use bold and italic for each token.

Note

This only adds this to theme settings which persists to the theme file when edited. We are not currently using this in our text view and this will need to be implemented in CodeEditTextView / CodeEditSourceEditor in order to see these settings reflected in the source editor.

Related Issues

n/a

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

Screen.Recording.2024-09-26.at.11.27.00.PM.mov

[thecoolwinter]

Thinking about future directions with themes, would it be better to use a weight: String? property rather than a boolean for bold? That'd allow for semibold, heavy, etc. when we eventually add those.

[austincondiff]

@thecoolwinter I don't think so. bold should make text bolder regardless of what weight is chosen as default. I am not sure off hand what this looks like in AppKit, but I know in SwiftUI there is a .bold() modifier that makes text bolder than it is regardless of the original weight (used here). This approach should be used when we implement this in CETV.

Looking at themes in Xcode, from what I've seen there is only ever bold and not bold, nothing in between.

[tom-ludwig]

Love the design!
Maybe we could use an array to store font changes for each word type, like:
"modifiers": ["italic", "bold", ...]
What do you think?

[austincondiff]

@activcoding because there are only two, I'd prefer to keep the API simple. If there were more boolean settings I'd consider that though.