Fix Edited Indicator Behavior

[Kihron]

Description

The edited indicator behavior now properly updates and aligns with Xcode's implementation.

The autosave() method provided by NSDocument automatically calls updateChangeCount accordingly. The else block in the function executed regardless of whether autosaving occurred or was enabled, triggering an unintended cleared state. As such, removing the direct call to updateChangeCount(.changeCleared) resolved the issue as the change count state is now handled properly by the autosave() method.

Related Issues

• The edited mark function is invalid #1898

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

With Manual Saving

Screen.Recording.2024-10-17.at.1.31.39.AM.mov

With Auto Save

Screen.Recording.2024-10-17.at.1.32.48.AM.mov

[tom-ludwig]

Could you please add a short comment above codeFile.autosave(...) to explain that updateChangeCount doesn’t need to be called manually?

[Kihron]

Just added a comment 👍

[tom-ludwig]

Perfect 👊🏼. Thank you very much