Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Navigator Area Label Truncation #1912

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix Navigator Area Label Truncation #1912

merged 1 commit into from
Oct 18, 2024

Conversation

Kihron
Copy link
Contributor

@Kihron Kihron commented Oct 17, 2024

Description

  • Adjusted logic for labels within the Navigator Area so that they truncate properly in all areas
  • Resolved an invalid frame error related to the height when using the search feature

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-10-17.at.2.08.24.PM.mov

@Kihron
- Adjusted logic for labels within the Navigator Area so that they tr…
03b8e92 
…uncate properly in all areas

- Resolved an invalid frame error related to the height when using the search feature
austincondiff
austincondiff approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the quick response! 🚀

@austincondiff austincondiff merged commit 8fe1b28 into CodeEditApp:main Oct 18, 2024
2 checks passed
@Kihron Kihron deleted the bugfix/issue-1911 branch October 18, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombardier200 bombardier200 bombardier200 approved these changes

@austincondiff austincondiff austincondiff approved these changes

@0xWDG 0xWDG Awaiting requested review from 0xWDG

@lukepistrol lukepistrol Awaiting requested review from lukepistrol

@FastestMolasses FastestMolasses Awaiting requested review from FastestMolasses

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kihron @austincondiff @bombardier200