Skip to content

[chore:] Update CodeEditSourceEditor, add Find In Editor, Misc Bug Fixes #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

[chore:] Update CodeEditSourceEditor, add Find In Editor, Misc Bug Fixes #2020

merged 3 commits into from
Apr 8, 2025

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Apr 7, 2025 •
edited
Loading

Description

Updates CodeEditSourceEditor.

Includes:

  • Find in Editor feature.
  • Improved undo grouping.
  • Improved word detection when selecting words.
  • Improved overscroll behavior.
  • Added mouse drag selection modes.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

FastestMolasses
FastestMolasses previously approved these changes Apr 7, 2025
View reviewed changes
0xWDG
0xWDG previously approved these changes Apr 7, 2025
View reviewed changes
@thecoolwinter
Copy link
Collaborator Author

Shoot sorry I pinged everyone here without reason, we need CodeEditApp/CodeEditSourceEditor#295 merged before this is ready.

@thecoolwinter thecoolwinter marked this pull request as draft April 7, 2025 20:10
@austincondiff
Copy link
Collaborator

This probably shouldn't close #1 because it doesn't address replace.

@thecoolwinter
Copy link
Collaborator Author

This probably shouldn't close #1 because it doesn't address replace.

Good call!

@thecoolwinter thecoolwinter dismissed stale reviews from 0xWDG and FastestMolasses via f5fd905 April 8, 2025 18:07
@thecoolwinter thecoolwinter marked this pull request as ready for review April 8, 2025 18:07
@thecoolwinter thecoolwinter merged commit f919bbb into CodeEditApp:main Apr 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xWDG 0xWDG 0xWDG left review comments

@FastestMolasses FastestMolasses FastestMolasses left review comments

@austincondiff austincondiff Awaiting requested review from austincondiff

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thecoolwinter @austincondiff @0xWDG @FastestMolasses