Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: svelte support #60

Closed

Conversation

EstebanBorai
Copy link
Member

Description

Provides support for Svelte

Related Issues

#59

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@EstebanBorai
Copy link
Member Author

I found some C linking issues when building CodeEditLanguages, all related to conflicts in duplicated symbols (a.k.a. function names), with similar implementations.

Linker Logs
duplicate symbol '_can_contain' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_deserialize' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_scan' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_scan_comment' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_scan_end_tag_name' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_scan_implicit_end_tag' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_scan_raw_text' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_scan_self_closing_tag_delimiter' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_scan_start_tag_name' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_scan_tag_name' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)
duplicate symbol '_serialize' in:
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterHTML.o)
    /Users/user/Library/Developer/Xcode/DerivedData/CodeEditLanguages-ebnxposdfmbvzxgdnlmbcnxsxahs/Build/Products/Debug/CodeLanguages_Container.framework/CodeLanguages_Container(TreeSitterSvelte.o)

Checking on source code for both Tree Sitter libraries I found that these functions are implemented in both:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant