Added specs and factory girl #284
Conversation
PraveenVignesh
commented
Dec 25, 2014
PraveenVignesh
commented
- added factory_girl_rails gem
- added faker gem
- created factories for models
- added specs for relationships
- added specs for scopes in model
|
Thanks for adding these! I'm seeing a lot of style changes here and wanted to check -- could you take a moment to use Thoughtbot's Hound to do a quick style guide of this pull request and make sure it fits the standard Ruby guidelines? We appreciate it, @PraveenVignesh! |
There was a problem hiding this comment.
Place the . on the previous line, together with the method call receiver.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Thanks @courte Is everything fine now? |
|
@PraveenVignesh - You're definitely closer! 👏 Check out the HoundCI comments above to see some of the remaining style guide issues. Also, the testing area of the codebase has changed quite a bit since you first submitted. For example, factory-girl has already been added, along with a number of new specs. You may want to take a few steps to get your version up to date.
That process will cut down on any work you might do fixing code that's not be relevant anymore. Let me know if you have any questions! |
spec/models/event_spec.rb
Outdated
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
spec/models/organization_spec.rb
Outdated
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
PraveenVignesh
force-pushed
the
add-specs-and-factory-girl
branch
from
e83733b to
f8c2086
Compare
spec/models/organization_spec.rb
Outdated
PraveenVignesh
force-pushed
the
add-specs-and-factory-girl
branch
2 times, most recently
from
7f6857c to
32e3cf3
Compare
PraveenVignesh
force-pushed
the
add-specs-and-factory-girl
branch
from
32e3cf3 to
84b7632
Compare
more style fixes added trait for job, event factories added traits for project, style fixes, merge fixes added trait for public event fixed job factory
PraveenVignesh
force-pushed
the
add-specs-and-factory-girl
branch
from
84b7632 to
01869f3
Compare
|
@courte I have fixed the style violations and rebase it with master. Please check this and give your feedback. |
3 participants
