Adding tweet to share button on project list and detail pages, refs #357. #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Share button in project partial Share button on project show page (pretend there's a logo instead of an ugly box) |
|
@juliaelman, thanks for working on this last week! For now, we'd prefer to keep the tweet button on the show page only - since adding it to the project partial brings up some design decisions we'd rather not make at the moment. I know you've got a lot going on this week! If you don't have time to make the change, don't hesitate to let me know. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps solve the initial parts of #357 by adding a Twitter share button to project list and detail pages.