Client pause-resume documents functionality#5
Open
ErdalDomi wants to merge 5 commits intoCodeWitchBella:masterfrom
Open
Client pause-resume documents functionality#5ErdalDomi wants to merge 5 commits intoCodeWitchBella:masterfrom
ErdalDomi wants to merge 5 commits intoCodeWitchBella:masterfrom
Conversation
Updated nodemon dependency to avoid flatstream-map package
Contributor
Author
|
I may have caused a conflict due to an improper pull request. I do apologize if that's the case since this is the first time I contribute to a project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
For a project I'm working on, it is desirable to not update the document (hence the UI) when a user is editing an input field. This would cause confusion
To remedy this, it is proposed to create two functions 'pause' and 'resume' that take an array of document ids. Once a document is paused, the onChange function will not add this document to the docSet (thus propagating changes to the server).
This suggestion actually comes from one of the main library contributors and creator:
Please take a look at the code and let me know if this looks good to you or anything should be changed to accommodate this kind of functionality
Thanks again for the library you created