Merge pull request #961 from Codeinwp/bugfix/960

Fixed PHP warnings
Codeinwp · Jul 25, 2024 · faa6216 · faa6216
2 parents bf5fce0 + 24fe619
commit faa6216
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/test-php.yml b/.github/workflows/test-php.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Setup PHP version
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '7.1'
+          php-version: '7.4'
           extensions: simplexml
       - name: Checkout source code
         uses: actions/checkout@v2
@@ -51,7 +51,7 @@ jobs:
       - name: Setup PHP version
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '7.1'
+          php-version: '7.4'
           extensions: simplexml, mysql
           tools: phpunit-polyfills
       - name: Checkout source code

diff --git a/includes/admin/feedzy-rss-feeds-import.php b/includes/admin/feedzy-rss-feeds-import.php
@@ -1243,7 +1243,7 @@ private function run_job( $job, $max ) {
 		$import_translation_lang  = get_post_meta( $job->ID, 'import_auto_translation_lang', true );
 		$max                      = $import_feed_limit;
 
-		if ( metadata_exists( $import_post_type, $job->ID, 'import_post_status' ) ) {
+		if ( metadata_exists( 'post', $job->ID, 'import_post_status' ) ) {
 			$import_post_status = get_post_meta( $job->ID, 'import_post_status', true );
 		} else {
 			add_post_meta( $job->ID, 'import_post_status', 'publish' );

diff --git a/includes/gutenberg/feedzy-rss-feeds-gutenberg-block.php b/includes/gutenberg/feedzy-rss-feeds-gutenberg-block.php
@@ -76,8 +76,8 @@ public function feedzy_gutenberg_scripts() {
 		);
 
 		// Enqueue editor block styles
-		wp_enqueue_style( 'feedzy-block-css', FEEDZY_ABSURL . 'css/feedzy-rss-feeds.css', '', $version );
-		wp_enqueue_style( 'feedzy-gutenberg-block-css', FEEDZY_ABSURL . 'js/build/style-block.css', '', $version );
+		wp_enqueue_style( 'feedzy-block-css', FEEDZY_ABSURL . 'css/feedzy-rss-feeds.css', array(), $this->version );
+		wp_enqueue_style( 'feedzy-gutenberg-block-css', FEEDZY_ABSURL . 'js/build/style-block.css', array(), $this->version );
 	}
 
 	/**

diff --git a/tests/e2e/specs/import.spec.js b/tests/e2e/specs/import.spec.js
@@ -144,7 +144,6 @@ test.describe( 'Feed Import', () => {
 		// Select the first post created by feeds import. Check the featured image.
 		await page.getByRole('link', { name: 'Posts', exact: true }).click({ force: true });
 		await page.locator('#the-list tr').first().locator('a.row-title').click({ force: true });
-		await page.getByRole('button', { name: 'Featured image' }).click({ force: true });
 		await expect( page.getByLabel('Edit or replace the image') ).toBeVisible(); // Featured image is added.
 	});