Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PHP warnings #961

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Fixed PHP warnings #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9a6262
fix: PHP warnings
girishpanchal30 Jul 19, 2024
92c625e
fix: PHPUnit testcase error
girishpanchal30 Jul 19, 2024
24b7d18
Fix phpunit testcase issue with WP 6.6
girishpanchal30 Jul 19, 2024
f79ce9f
fix: e2e error
girishpanchal30 Jul 19, 2024
24fe619
e2e: remove set featured image
girishpanchal30 Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup PHP version
uses: shivammathur/setup-php@v2
with:
php-version: '7.1'
php-version: '7.4'
extensions: simplexml
- name: Checkout source code
uses: actions/checkout@v2
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Setup PHP version
uses: shivammathur/setup-php@v2
with:
php-version: '7.1'
php-version: '7.4'
extensions: simplexml, mysql
tools: phpunit-polyfills
- name: Checkout source code
Expand Down
2 changes: 1 addition & 1 deletion includes/admin/feedzy-rss-feeds-import.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,7 +1243,7 @@ private function run_job( $job, $max ) {
$import_translation_lang = get_post_meta( $job->ID, 'import_auto_translation_lang', true );
$max = $import_feed_limit;

if ( metadata_exists( $import_post_type, $job->ID, 'import_post_status' ) ) {
if ( metadata_exists( 'post', $job->ID, 'import_post_status' ) ) {
$import_post_status = get_post_meta( $job->ID, 'import_post_status', true );
} else {
add_post_meta( $job->ID, 'import_post_status', 'publish' );
Expand Down
4 changes: 2 additions & 2 deletions includes/gutenberg/feedzy-rss-feeds-gutenberg-block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ public function feedzy_gutenberg_scripts() {
);

// Enqueue editor block styles
wp_enqueue_style( 'feedzy-block-css', FEEDZY_ABSURL . 'css/feedzy-rss-feeds.css', '', $version );
wp_enqueue_style( 'feedzy-gutenberg-block-css', FEEDZY_ABSURL . 'js/build/style-block.css', '', $version );
wp_enqueue_style( 'feedzy-block-css', FEEDZY_ABSURL . 'css/feedzy-rss-feeds.css', array(), $this->version );
wp_enqueue_style( 'feedzy-gutenberg-block-css', FEEDZY_ABSURL . 'js/build/style-block.css', array(), $this->version );
}

/**
Expand Down
1 change: 0 additions & 1 deletion tests/e2e/specs/import.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ test.describe( 'Feed Import', () => {
// Select the first post created by feeds import. Check the featured image.
await page.getByRole('link', { name: 'Posts', exact: true }).click({ force: true });
await page.locator('#the-list tr').first().locator('a.row-title').click({ force: true });
await page.getByRole('button', { name: 'Featured image' }).click({ force: true });
await expect( page.getByLabel('Edit or replace the image') ).toBeVisible(); // Featured image is added.
});

Expand Down
Loading