Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images present in cart are not being optimised by optimole #753

Open
kushh23 opened this issue Dec 14, 2023 · 16 comments · May be fixed by #826
Open

Images present in cart are not being optimised by optimole #753

kushh23 opened this issue Dec 14, 2023 · 16 comments · May be fixed by #826
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@kushh23
Copy link

kushh23 commented Dec 14, 2023

Description

If you add a product to the cart, then the images on the cart page are not optimized by Optimole. Is this intended for some reason? or a bug?

Step-by-step reproduction instructions

  1. Add a product to the cart.
  2. Check if the image is optimized on the same product page when the noticed appears on page that product is added.
  3. Go to cart page and check the product images.

Screenshots, screen recording, code snippet or Help Scout ticket

It can be quickly verified here - https://travelbirthday.s4-tastewp.com/shop/
Screenshot from 2023-12-14 20-16-07
Screenshot from 2023-12-14 20-15-44

Environment info

https://pastebin.com/g5NGg48m

Is the issue you are reporting a regression

No

@kushh23 kushh23 added the bug This label could be used to identify issues that are caused by a defect in the product. label Dec 14, 2023
@girishpanchal30
Copy link
Contributor

@kushh23 I've checked with tastewp test instance and it seems working fine for me.
Ref: https://tinyurl.com/26jtuzcz

You can check here - https://defectivehill.s4-tastewp.com/shop/

Thanks

@kushh23
Copy link
Author

kushh23 commented Aug 29, 2024

@girishpanchal30 I am still able to replicate this on my tastewp instance, see here - https://vertis.d.pr/i/A9sTJd

https://briefmiddle.s3-tastewp.com/shop
Kushnamdev
vEQ2I65vd#J*ynkQV$pHl2^K

Do you have any idea why this happens on my end?

Thank you!

@girishpanchal30
Copy link
Contributor

@kushh23 I found the issue: we selected the "Optimole Cloud and your website" option, which is causing it to display the local image path.

image

I'll check this issue and let you know here.

Thanks

@girishpanchal30 girishpanchal30 linked a pull request Aug 30, 2024 that will close this issue
6 tasks
@girishpanchal30 girishpanchal30 linked a pull request Aug 30, 2024 that will close this issue
6 tasks
@girishpanchal30
Copy link
Contributor

@kushh23 I've fixed this here - #826, Chould please check with mentioned PR?

@kushh23
Copy link
Author

kushh23 commented Sep 2, 2024

@girishpanchal30 I have tested the issue and can confirm that the PR build fixes the issue mentioned.

Thank you!

@kushh23
Copy link
Author

kushh23 commented Sep 2, 2024

Hi @girishpanchal30

I noticed one issue now with this PR build. After installing this build, the offloading process is no longer working correctly, I have tested it on a new instance as well.

Steps:
1- Install the PR build.
2- Check the initial issue - It is solved
3- Now enable the offloading option (Optimole cloud only) and check again if the images are offloaded or not.
4- You will notice that the images are not offloaded even after you are trying to "Sync" them again.

Attached Screenshot :
image
image

@girishpanchal30
Copy link
Contributor

@kushh23 I've fixed it with the latest commit, Can you please recheck with the newest build zip?

@kushh23
Copy link
Author

kushh23 commented Sep 2, 2024

@girishpanchal30 I checked with the latest build and its not fixing the issue.

You can also test it here -
https://scintillatinghair.s1-tastewp.com/wp-admin/
kushnamdev
zQcI997p*7Me1&5qVnX@pD

@girishpanchal30
Copy link
Contributor

@kushh23 Provided test instance details are not working.

I've checked with my test instance and it seems working.
Ref: https://tinyurl.com/2b2gee56

https://nimblerequest.s3-tastewp.com/wp-admin

girish / T)ENN%rAB1B4kFt0RvJECLkv

@kushh23
Copy link
Author

kushh23 commented Sep 2, 2024

@girishpanchal30 I have checked the issue on your site too and its not fixing the offload issue there either. Please check the media library page to verify image is offloaded or not (by checking the URL of files), currently it is being Optimised by Optimole but not offloaded.

image

@girishpanchal30
Copy link
Contributor

@kushh23

Now enable the offloading option (Optimole cloud only) and check again if the images are offloaded or not.

After changing the offloading option it will work for new uploads. - https://tinyurl.com/233x6moa

In this PR, I've fixed the WC Cart related issue you can create a new ticket for another issue.

Thanks

@kushh23
Copy link
Author

kushh23 commented Sep 3, 2024

@girishpanchal30 yes, I understand the point that it will work for new uploads, but the Pr build is affecting the offloading process for existing images. It shouldn't affect user's existing images, i.e., if the user has existing images, they won't offload. For more clarity, I have recorded this screencast - https://vertis.d.pr/v/RBSJoS

cc:@selul

@girishpanchal30
Copy link
Contributor

@kushh23 I reviewed the existing media images, and everything appears to be in sync on my end.

Ref: https://tinyurl.com/28y5syoy, https://tinyurl.com/25vl39eh

I've check here: https://fourmove.s4-tastewp.com/wp-admin/upload.php?mode=list

girish / hdzxxBBzgskr$iNENKMy2X1j

@kushh23
Copy link
Author

kushh23 commented Sep 3, 2024

Hi @girishpanchal30,

I was able to replicate the issue on your new test site as well. The problem only occurs after installing the PR build. You can see it in the screencast: https://vertis.d.pr/v/EjTQlQ

I rolled back the plugin to the latest version of Optimole, then added an image (with offloading disabled) to a product. After installing the plugin from the pull request, the image stops being offloaded.

Please review the screencast and let me know if there is any confusion.

Best regards

@girishpanchal30
Copy link
Contributor

@kushh23 I've made some modifications to the load filter only on the cart page. Please check the latest build zip and let me know if you have any issues.

@kushh23
Copy link
Author

kushh23 commented Sep 9, 2024

@girishpanchal30 Sorry for the delay, but I am still not able to offload the existing images prior to the plugin build installation; this is true for all type of images present on the site ( not necessarily connected to Woo products)

https://vertis.d.pr/v/hqZBg7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants