-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images present in cart are not being optimised by optimole #753
Comments
@kushh23 I've checked with You can check here - https://defectivehill.s4-tastewp.com/shop/ Thanks |
@girishpanchal30 I am still able to replicate this on my
Do you have any idea why this happens on my end? Thank you! |
@kushh23 I found the issue: we selected the "Optimole Cloud and your website" option, which is causing it to display the local image path. I'll check this issue and let you know here. Thanks |
@girishpanchal30 I have tested the issue and can confirm that the PR build fixes the issue mentioned. Thank you! |
I noticed one issue now with this PR build. After installing this build, the offloading process is no longer working correctly, I have tested it on a new instance as well. Steps: |
@kushh23 I've fixed it with the latest commit, Can you please recheck with the newest build zip? |
@girishpanchal30 I checked with the latest build and its not fixing the issue. You can also test it here - |
@kushh23 Provided test instance details are not working. I've checked with my test instance and it seems working. https://nimblerequest.s3-tastewp.com/wp-admin girish / T)ENN%rAB1B4kFt0RvJECLkv |
@girishpanchal30 I have checked the issue on your site too and its not fixing the offload issue there either. Please check the media library page to verify image is offloaded or not (by checking the URL of files), currently it is being Optimised by Optimole but not offloaded. |
After changing the In this PR, I've fixed the Thanks |
@girishpanchal30 yes, I understand the point that it will work for new uploads, but the Pr build is affecting the offloading process for existing images. It shouldn't affect user's existing images, i.e., if the user has existing images, they won't offload. For more clarity, I have recorded this screencast - https://vertis.d.pr/v/RBSJoS cc:@selul |
@kushh23 I reviewed the existing media images, and everything appears to be in sync on my end. Ref: https://tinyurl.com/28y5syoy, https://tinyurl.com/25vl39eh I've check here: https://fourmove.s4-tastewp.com/wp-admin/upload.php?mode=list girish / hdzxxBBzgskr$iNENKMy2X1j |
Hi @girishpanchal30, I was able to replicate the issue on your new test site as well. The problem only occurs after installing the PR build. You can see it in the screencast: https://vertis.d.pr/v/EjTQlQ I rolled back the plugin to the latest version of Optimole, then added an image (with offloading disabled) to a product. After installing the plugin from the pull request, the image stops being offloaded. Please review the screencast and let me know if there is any confusion. Best regards |
@kushh23 I've made some modifications to the load filter only on the cart page. Please check the latest build zip and let me know if you have any issues. |
@girishpanchal30 Sorry for the delay, but I am still not able to offload the existing images prior to the plugin build installation; this is true for all type of images present on the site ( not necessarily connected to Woo products) |
Description
If you add a product to the cart, then the images on the cart page are not optimized by Optimole. Is this intended for some reason? or a bug?
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet or Help Scout ticket
It can be quickly verified here - https://travelbirthday.s4-tastewp.com/shop/
Environment info
https://pastebin.com/g5NGg48m
Is the issue you are reporting a regression
No
The text was updated successfully, but these errors were encountered: