Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed optimised image issue with the WC cart page #826

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

girishpanchal30
Copy link
Contributor

@girishpanchal30 girishpanchal30 commented Aug 30, 2024

All Submissions:

Changes proposed in this Pull Request:

It appears that the $this->settings->use_lazyload() condition is causing the filters to be skipped, and the image_downsize filter is needed to replace the optimized image and fix the issue with WC Cart items.

Closes #753

How to test the changes in this Pull Request:

  1. Add a product to the cart.
  2. Check if the image is optimized on the same product page when the noticed appears on page that product is added.
  3. Go to cart page and check the product images.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@pirate-bot
Copy link
Collaborator

pirate-bot commented Aug 30, 2024

Plugin build for e9dd1d0 is ready 🛎️!

@selul selul requested review from selul and removed request for abaicus, Soare-Robert-Daniel and selul September 6, 2024 06:38
@vytisbulkevicius vytisbulkevicius added the on-hold Not being actively worked by being blocked or not having the capacity to work on it. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold Not being actively worked by being blocked or not having the capacity to work on it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images present in cart are not being optimised by optimole
3 participants