Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SDK function for upgrade links and survey #2416

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 31, 2024

Closes #2375

Summary

  • Add lang code to upgrade links.
  • Use Formbricks from SDK, which enhances the payload with the lang code

Test instructions

  • In the dashboard, check if survey_deps is loaded into the page.
  • Check if the upgrade links have lang=de when WP is set to German.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 31, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 31, 2024 11:40
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 31, 2024
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.41 KB 271.41 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB 0 B (0.00%)
CSS 100.89 KB 100.89 KB 0 B (0.00%)
Dashboard 198.45 KB 197.17 KB -1.28 KB (-0.64%)
Onboarding 161.1 KB 161.1 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 423.65 KB 423.65 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 31, 2024

Plugin build for f0956ea is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 31, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 237.75, firstPaint: 548.3, domContentLoaded: 1551.85, loaded: 1552.7, firstContentfulPaint: 3415.7, firstBlock: 7636.95, type: 11.65, minType: 10.7, maxType: 12.72, typeContainer: 8.47, minTypeContainer: 7.7, maxTypeContainer: 11.38, focus: 33.62, minFocus: 28.68, maxFocus: 42.04, inserterOpen: 22.09, minInserterOpen: 19.4, maxInserterOpen: 27.07, inserterSearch: 0.71, minInserterSearch: 0.59, maxInserterSearch: 0.92, inserterHover: 3.69, minInserterHover: 2.56, maxInserterHover: 5.24, listViewOpen: 143.9, minListViewOpen: 128.62, maxListViewOpen: 165.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants