-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SDK function for upgrade links and survey #2416
Open
Soare-Robert-Daniel
wants to merge
2
commits into
development
Choose a base branch
from
fix/use-sdk-functions
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Oct 31, 2024
Bundle Size Diff
|
Plugin build for f0956ea is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 237.75, firstPaint: 548.3, domContentLoaded: 1551.85, loaded: 1552.7, firstContentfulPaint: 3415.7, firstBlock: 7636.95, type: 11.65, minType: 10.7, maxType: 12.72, typeContainer: 8.47, minTypeContainer: 7.7, maxTypeContainer: 11.38, focus: 33.62, minFocus: 28.68, maxFocus: 42.04, inserterOpen: 22.09, minInserterOpen: 19.4, maxInserterOpen: 27.07, inserterSearch: 0.71, minInserterSearch: 0.59, maxInserterSearch: 0.92, inserterHover: 3.69, minInserterHover: 2.56, maxInserterHover: 5.24, listViewOpen: 143.9, minListViewOpen: 128.62, maxListViewOpen: 165.22 |
Soare-Robert-Daniel
force-pushed
the
fix/use-sdk-functions
branch
from
October 31, 2024 12:27
469445e
to
f0956ea
Compare
HardeepAsrani
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2375
Summary
Test instructions
survey_deps
is loaded into the page.lang=de
when WP is set to German.Checklist before the final review