Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add banner support #1190

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat: add banner support #1190

merged 2 commits into from
Nov 7, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 1, 2024

Summary

Add SDK banner support.

Will affect visual aspect of the product

YES

Screenshots

image

Test instructions

Must be used with https://github.com/Codeinwp/themeisle-sdk/pull/269

  • Set the instance date between 25 NOV and 3 DEC to trigger Black Friday banner
  • You should see the banner on the Library page.
  • You should NOT see the banner if it is not a Blackfriday Interval

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/themeisle/issues/1688

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 1, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 1, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review November 5, 2024 08:57
@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 5, 2024

Plugin build for 2785309 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 5, 2024
Copy link
Contributor

@abaicus abaicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soare-Robert-Daniel I just left one thing. If you're sure the condition looks good and applies to all pro users, then it's fine. I'd still review it though.

classes/Visualizer/Module/Admin.php Show resolved Hide resolved
@vytisbulkevicius vytisbulkevicius merged commit 8609f98 into development Nov 7, 2024
7 checks passed
@vytisbulkevicius vytisbulkevicius deleted the feat/banner branch November 7, 2024 07:59
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.11.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants