-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add banner support #1190
Merged
Merged
feat: add banner support #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soare-Robert-Daniel
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
Nov 1, 2024
Soare-Robert-Daniel
force-pushed
the
feat/banner
branch
from
November 1, 2024 14:16
53df336
to
c74ddb5
Compare
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Nov 5, 2024
abaicus
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Soare-Robert-Daniel I just left one thing. If you're sure the condition looks good and applies to all pro users, then it's fine. I'd still review it though.
abaicus
approved these changes
Nov 6, 2024
Soare-Robert-Daniel
force-pushed
the
feat/banner
branch
from
November 6, 2024 13:02
26ebdc4
to
f56b051
Compare
Soare-Robert-Daniel
force-pushed
the
feat/banner
branch
from
November 6, 2024 15:35
f56b051
to
2785309
Compare
🎉 This PR is included in version 3.11.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add SDK banner support.
Will affect visual aspect of the product
YES
Screenshots
Test instructions
Must be used with https://github.com/Codeinwp/themeisle-sdk/pull/269
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/themeisle/issues/1688