Add redbot-setup restore cli command for restoring instance from backup#3681
Draft
Jackenmen wants to merge 14 commits intoCog-Creators:V3/developfrom
Draft
Add redbot-setup restore cli command for restoring instance from backup#3681Jackenmen wants to merge 14 commits intoCog-Creators:V3/developfrom
redbot-setup restore cli command for restoring instance from backup#3681Jackenmen wants to merge 14 commits intoCog-Creators:V3/developfrom
Conversation
Member
Author
|
This PR is ready for review. Or at least as ready as it can be - restoring cogs is still far from perfect as it requires running I decided to finish it up anyway and we can decide later in the org whether we want to freeze this until appropriate rewriting is done or if the feature is good enough to ship it before that's done. |
297882c to
b513c32
Compare
ad7a33d to
263767e
Compare
263767e to
2da1056
Compare
3 tasks
2c9f3d0 to
5a9a55d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Fixes #2947
I added progress bars to indicate to the user that the command does something but they're surely not the most accurate progress bars - progress bar for (un)packing archives are based on file amount, not on file size and progress bar for downloading repos is based on repo amount. I'm open to improving it but I think it still serves its purpose even if it's not very linear.
Note:
Restoring cogs is still far from perfect as it requires running
[p]cog updateafter the offline restoring process so that the previously installed cogs get reinstalled (it's totally possible to reinstall cogs offline but it would require rewriting more than I currently have time for).I decided to finish it up anyway and we can decide later in the org whether we want to freeze this until appropriate rewriting is done or if the feature is good enough to ship it before that's done.
Other minor fixes/enhancements:
redbot-setupandredbot --editno longer stops whole process and instead asks for the path againredbot-setup deleteno longer tries to connect to database if user doesn't want to delete instance's data--debugis now a flag inredbot-setupto be consistent withredbotnote to self: rebase push was: 2c9f3d0...5a9a55d