C++ Misc Cleanup: More override, std-header, std::make_* usage, .. #10012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
- Use override for virtual function overrides (incl. dtor) - Use C++ std headers, e.g. cctype instead of ctype.h - Use global anonym namespace for system functions or std:: system functions, whichever is applicable - Use std::make_shared<StreamSocket>(..) - Use std::make_unique<Watchdog>() - Use 'const' where applicable - Use pre-incr where applicable - Use typename where applicable - Drop redundant type conversions Signed-off-by: Sven Göthel <[email protected]> Change-Id: Id844187c82fce3c6e9bceb512c07180705608ebc
sgothel
force-pushed
the
private/sgothel/cleanup_02
branch
from
6d9ea3f to
718ad77
Compare
caolanm
approved these changes
Sep 9, 2024
| @@ -1087,21 +1087,21 @@ std::shared_ptr<Socket> ServerSocket::accept() | |||
| const void *inAddr; | |||
| if (clientInfo.sin6_family == AF_INET) | |||
| { | |||
| auto ipv4 = (struct sockaddr_in *)&clientInfo; | |||
| struct sockaddr_in *ipv4 = (struct sockaddr_in *)&clientInfo; | |||
There was a problem hiding this comment.
we could probably replace the c-style "struct sockaddrWhatever" with c++-style "sockaddrWhatever", but that's just an observation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change-Id: Id844187c82fce3c6e9bceb512c07180705608ebc
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay