feat(UI): Overflow menu (Switch from scroll button to dropdown) #10124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
maks-w
force-pushed
the
maks-w/overflow-menu
branch
2 times, most recently
from
9e21d3c to
33f523a
Compare
|
Hello, I would love some feedback before I go further, maybe @pedropintosilva ? Thank you |
eszkadev
reviewed
Oct 22, 2024
| @@ -226,14 +227,123 @@ class TopToolbar extends JSDialog.Toolbar { | |||
| } | |||
| } | |||
|
|
|||
| createOverflowMenu() { | |||
There was a problem hiding this comment.
nice, would be also good to use our helper for popups: https://github.com/CollaboraOnline/online/blob/master/browser/src/control/jsdialog/Util.Dropdown.js#L22
example usage:
Signed-off-by: Maks Wolkowinski <[email protected]> Change-Id: I80c76c9511ceec9d3e46a261ce8ffefc1d5aa477
maks-w
force-pushed
the
maks-w/overflow-menu
branch
from
33f523a to
f39ae91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I80c76c9511ceec9d3e46a261ce8ffefc1d5aa477
Summary
I only did the classic menu as a proof of concept, i'm not sure what would be the spec for the notebookbar (it seems to me that it would be weird to have a second bar that is as wide?).
I took the liberty of hiding by section and not just by button. This approach has the benefit of not having half of the features in the top bar and the rest in the overflow menu.
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay