Add concurrent TCP connections to 'getMetrics' REST endpoint #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/sgothel/prometheus_connections
branch
from
ac66440 to
1f6cdc4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sgothel
force-pushed
the
private/sgothel/prometheus_connections
branch
from
1f6cdc4 to
80c2798
Compare
5 tasks
5 tasks
|
In this PR the first three patches are already in #10375 and that last one is AFAICS independent of the others in the sense that it builds without them, so we could drop those here and just get that piece in without requiring the rest so this could be merged independently |
sgothel
force-pushed
the
private/sgothel/prometheus_connections
branch
from
80c2798 to
be58fac
Compare
6 tasks
mmeeks
requested changes
Nov 13, 2024
sgothel
force-pushed
the
private/sgothel/prometheus_connections
branch
from
be58fac to
e4aea4b
Compare
mmeeks
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Fine - but I don't want to have to re-review and re-approve the Closed patch underneath it - I really don't understand why that is included. It is orthogonal & serves only to waste scarce review time. Surely creating a branch and cherry-picking one patch is achievable ?
…Metrics' REST endpoint Signed-off-by: Sven Göthel <[email protected]> Change-Id: I68dccec09e7907a5d3561a3df10637b30815bcc1
sgothel
force-pushed
the
private/sgothel/prometheus_connections
branch
from
e4aea4b to
a74ca83
Compare
mmeeks
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add max/used concurrent TCP connections to Prometheus text-based 'getMetrics' REST endpoint
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay